This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
This is the cleanup patch mentioned earlier, plus a few other things - In fhandler_base::open_fs I changed the call to set_file_attribute as you already did recently in mkdir and symlink_worker, and - I also eliminated the test of GetLastError. After all, CreateFile did succeed so the LastError is meaningless. - I noticed that the test (fh) had to me moved up in stat_worker, and I applied the same test in chown_worker, chmod and access. While I was at it I removed PC_FULL, which is automatic in fhandlers. In stat_worker I added a check for the path existence (for speed). Pierre 2004-04-19 Pierre Humblet <pierre.humblet@ieee.org> * fhandler_disk_file.cc (fhandler_base::open_fs): Change set_file_attribute call to indicate that NT security isn't used. Remove call to GetLastError. (fhandler_disk_file::fchmod): Rearrange to isolate 9x related statements. Do not set FILE_ATTRIBUTE_SYSTEM. (fhandler_disk_file::fchown): Check noop case first. * fhandler.cc (fhandler_base::open9x): Remove ntsec related statements. (fhandler_base::set_name): Do not set namehash. * fhandler.h (fhandler_base::get_namehash): Compute and set namehash if needed. * syscalls (access): Verify that fh is not NULL. Do not set PC_FULL. (chmod): Ditto. (chown_worker): Ditto. (stat_worker): Ditto. Verify if the path exists.
Attachment:
chown.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |