This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] cygcheck: pretty_id misbehaving.


Op Sun, 17 Oct 2004 21:46:29 -0400 schreef Christopher Faylor
in <20041018014629.GO29569@trixie.casa.cgf.cx>:
:  On Mon, Oct 18, 2004 at 03:32:07AM +0200, Buzz wrote:

[...]

: > 	* Cygcheck.cc (pretty_id): Count ')' in ui_len and gui_len.
:
:   Thanks.  Checked in without change.

Thank you (for writing a better ChangeLog-entry as well).

Remaining items... (I missed these last time around.)


ChangeLog-entry:

2004-10-18  Bas van Gompel  <cygwin-patch.buzz@bavag.tmfweb.nl>

	* cygcheck.cc (pretty_id): Don't let i become negative. Fix
	printf-format.


--- src/winsup/utils/cygcheck.cc	18 Oct 2004 01:44:55 -0000	1.52
+++ src/winsup/utils/cygcheck.cc	18 Oct 2004 04:47:24 -0000
@@ -836,11 +836,11 @@ pretty_id (const char *s, char *cygwin, 
 
   printf ("\nOutput from %s (%s)\n", id, s);
   int n = 80 / (int) ++sz;
-  int i = n ? n - 2 : 0;
+  int i = n > 2 ? n - 2 : 0;
   sz = -sz;
   for (char **g = groups; g <= ng; g++)
     if ((g != ng) && (++i < n))
-      printf ("%*s ", sz, *g);
+      printf ("%*s", sz, *g);
     else
       {
 	puts (*g);


L8r,

Buzz.
-- 
  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   /    /   really is |   and false bits entirely.    | mail for
  ) |  |  /    /    a 72 by 4 +-------------------------------+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."    | me. 4^re


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]