This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to allow trailing dots on managed mounts


Which is why I did what I did.
If you look, my patch allows for checking to see 
if "............................." was entered as an argument, and 
throws the exception if it was.  THEN, if that is not the case,
it passes the FULL name to conv_to_win32_path to allow
for proper demangling rules.


On Thu, 16 Dec 2004 11:09:50 -0500, Christopher Faylor wrote:

>On Thu, Dec 16, 2004 at 11:06:07AM -0500, Christopher Faylor wrote:
>>On Thu, Dec 16, 2004 at 05:03:22PM +0100, Corinna Vinschen wrote:
>>>On Dec 16 10:57, Christopher Faylor wrote:
>>>> On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
>>>> >Since the mount code is called from path_conv anyway, wouldn't it be
>>>> >better to pass the information "managed mount or not" up to path_conv?
>>>> 
>>>> How about just doing the pathname munging in `conv_to_win32_path' if/when
>>>> it's needed?
>>>
>>>Erm... I'm not quite sure, but didn't the "remove trailing dots and spaces"
>>>code start there and has been moved to path_conv by Pierre to circumvent
>>>some problem?  I recall only very vaguely right now.
>>
>>One problem that it would circumvent is that currently, if you do this:
>>
>>ls /bin......................................
>>
>>You'll get a listing of the bin directory.  If you move the code to
>>conv_to_win32_path that may not be as easy to get right.

>That's the problem with somehow getting the information back to
>path_conv::check, too, I think.  It's a chicken/egg situation.  You need
>to regularize the path name before looking through the mount table to
>find out if the file is controlled by a managed mount.

>cgf




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]