This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Set FILE_ATTRIBUTE_TEMPORARY on files opened by mkstemp() on WinNT
- From: Christopher Faylor <cgf-no-personal-reply-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 21 Jul 2005 19:43:56 -0400
- Subject: Re: [PATCH] Set FILE_ATTRIBUTE_TEMPORARY on files opened by mkstemp() on WinNT
- References: <20050722011722.L38147@logout.sh.cvut.cz>
- Reply-to: cygwin-patches at cygwin dot com
On Fri, Jul 22, 2005 at 01:32:50AM +0200, Vaclav Haisman wrote:
>the attached patch sets FILE_ATTRIBUTE_TEMPORARY on files opened by
>mkstemp() on WinNT class systems. Theoretically the OS should then be
>less eager to write such files onto the physical storage and use cache
>instead.
Thank you for the patch but unless you can demonstrate some obvious
performance improvements I don't think we'll be applying it. You've
slowed down (slightly) the common case of calling open for the uncommon
case of calling mk?temp.
Also, if this was to be accepted, the preference for this type of thing
is to add a capability like wincap.has_file_attribute_temporary () rather
than just relying on is_winnt ().
cgf