This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Correctly compute whether the process is a non-Cygwin process in spawn_guts


On Thu, Jan 05, 2006 at 10:31:36AM -0500, Igor Peshansky wrote:
>On Thu, 5 Jan 2006, Christopher Faylor wrote:
>
>> On Thu, Jan 05, 2006 at 09:46:46AM -0500, Igor Peshansky wrote:
>> >The attached patch fixes the "no output from commands invoked through
>> >ssh" for me.  The ChangeLog is below.
>> >	Igor
>> >==============================================================================
>> >2006-01-05  Igor Peshansky  <pechtcha@cs.nyu.edu>
>> >
>> >	* spawn.cc (spawn_guts): Invert the argument to
>> >	set_console_state_for_spawn.
>>
>> Did you happen to notice the name of the argument to
>> "set_console_state_for_spawn"?
>
>Yes, I did.  It's supposed to be true for a non-Cygwin process and false
>for a Cygwin process.  IIUC, my patch makes it so.

Agh.  You're right.  I'm an idiot.  I misread the patch.  I even looked at the source
code and still got it wrong.

I'll apply the patch and then go sit in the corner for a while.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]