This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to mapping up to 128 SCSI Disk Devices


On Nov 13 16:42, Loh, Joe wrote:
> 
> This is a modified patch for up to 128 SCSI Disk Devices as discussed in
> http://cygwin.com/ml/cygwin/2006-11/msg00060.html.
> 
> As suggested by Eric Blake, we have snail mailed the copyright
> assignment to Rose Naftaly.

This will take a couple of days, probably.  In the meantime...

> Index: devices.h
> ===================================================================

I must admit that I don't quite understand why that happens, but
when I save your patch into a file, all '=' characters are converted
into a '=3D' sequence.  This is a bit weird given that you're using
us-ascii encoding.  Does anybody know why this happens?

> +++ devices.in  13 Nov 2006 22:30:44 -0000
> @@ -85,7 +85,15 @@
>  "/dev/scd%(0-15)d", BRACK(FHDEV(DEV_CDROM_MAJOR, {$1})),
> "\\Device\\CdRom{$1}"
>  "/dev/sr%(0-15)d", BRACK(FHDEV(DEV_CDROM_MAJOR, {$1})),
> "\\Device\\CdRom{$1}"
>  "/dev/sd%{a-z}s", BRACK(FH_SD{uc $1}), "\\Device\\Harddisk{ord($1) -
> ord('a')}\\Partition0"
> +"/dev/sda%{a-z}s", BRACK(FH_SDA{uc $1}), "\\Device\\Harddisk{26 +
> ord($1) - ord('a')}\\Partition0"
> +"/dev/sdb%{a-z}s", BRACK(FH_SDB{uc $1}), "\\Device\\Harddisk{52 +
> ord($1) - ord('a')}\\Partition0"
> +"/dev/sdc%{a-z}s", BRACK(FH_SDC{uc $1}), "\\Device\\Harddisk{78 +
> ord($1) - ord('a')}\\Partition0"
> +"/dev/sdd%{a-x}s", BRACK(FH_SDD{uc $1}), "\\Device\\Harddisk{104 +
> ord($1) - ord('a')}\\Partition0"
> [...]

The patch is also broken due to unexpected line breaks, see above.

> +  else if (drive < 112)          // /dev/sdcs -to- /dev/sddh
> +    {
> +      base = DEV_SD6_MAJOR;
> +      drive -= 96;
> +    }
> +  // NOTE: This will cause multiple /dev/sddx entries in
> +  //       /proc/partitions if there are more than 128 devices

Any problem to fix that and to get rid of this comment?  If not,
can you please convert the comment to C-style /**/?


Thanks for the patch.  We have to wait for Rose now, though.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]