This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Cygheap page boundary allocation bug.


On 11 December 2007 15:37, Corinna Vinschen wrote:

> On Dec 11 15:24, Dave Korn wrote:
>>   Applied, thanks.  (Found some problems in w32api's wincrypt.h which I'll
>> report to mingw list later today.  Appears to have been there for at least
>> a fortnight.  Am I the only one who builds with WINVER >= 0x0501?)
> 
> Unlikely but possible.  Cygwin is using _WIN32_WINNT=0x0501 in winsup.h
> and it doesn't have a build problem.


  AFAICT, there's no way on earth that what's in cvs could possibly compile.  It
uses the PCERT_POLICY_MAPPING structure typedef for a member of another struct
before it (PCERT_POLICY_MAPPING) has been defined.  There's also an undefined
type referenced in one of the function prototypes.  I had to do this:


Index: winsup/w32api/include/wincrypt.h
===================================================================
RCS file: /cvs/src/src/winsup/w32api/include/wincrypt.h,v
retrieving revision 1.22
diff -p -u -r1.22 wincrypt.h
--- winsup/w32api/include/wincrypt.h	22 Nov 2007 03:16:15 -0000	1.22
+++ winsup/w32api/include/wincrypt.h	11 Dec 2007 15:17:30 -0000
@@ -658,6 +658,8 @@ typedef struct _CRYPT_ENCODE_PARA {
 } CRYPT_ENCODE_PARA, 
  *PCRYPT_ENCODE_PARA;
 
+/* Definition missing. */
+typedef struct _CRYPT_DECODE_PARA *PCRYPT_DECODE_PARA;
 
 typedef UINT ALG_ID;
 typedef struct _VTableProvStruc {FARPROC FuncVerifyImage;}
VTableProvStruc,*PVTableProvStruc;
@@ -982,16 +984,16 @@ typedef struct _CERT_POLICY_CONSTRAINTS_
  *PCERT_POLICY_CONSTRAINTS_INFO;
 #endif /* (WINVER >= 0x0410) */ /* Windows 98 */
 #if (WINVER >= 0x0501) /* Windows Server 2003, Windows XP */
-typedef struct _CERT_POLICY_MAPPINGS_INFO {
-  DWORD cPolicyMapping;
-  PCERT_POLICY_MAPPING rgPolicyMapping;
-} CERT_POLICY_MAPPINGS_INFO, 
- *PCERT_POLICY_MAPPINGS_INFO;
 typedef struct _CERT_POLICY_MAPPING {
   LPSTR pszIssuerDomainPolicy;
   LPSTR pszSubjectDomainPolicy;
 } CERT_POLICY_MAPPING, 
  *PCERT_POLICY_MAPPING;
+typedef struct _CERT_POLICY_MAPPINGS_INFO {
+  DWORD cPolicyMapping;
+  PCERT_POLICY_MAPPING rgPolicyMapping;
+} CERT_POLICY_MAPPINGS_INFO, 
+ *PCERT_POLICY_MAPPINGS_INFO;
 #endif /* (WINVER >= 0x0501) */ /* Windows Server 2003, Windows XP */
 
 BOOL WINAPI CertCloseStore(HCERTSTORE,DWORD);


before I could build winsup.  Dunno why it's not affecting everyone else too.

    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]