This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Avoid duplicate names in /proc/registry (which may crash find)


On Dec 15 21:31, Christian Franke wrote:
> Corinna Vinschen wrote:
>> On Dec 13 14:37, Christian Franke wrote:
>>   
>>>
>>> 2008-12-13  Christian Franke  <franke@computer.org>
>>>
>>> 	* fhandler_registry.cc (DEFAULT_VALUE_NAME): Remove constant.
>>> 	(encode_regname): Encode empty (default) name to "@".
>>> 	Encode "@" to "%40".  Change error return to -1.
>>> 	(decode_regname): Decode "@" to empty name.  Decode "%40" to "@".
>>> 	(fhandler_registry::exists): Skip check for keys if name is empty.
>>> 	Remove check for DEFAULT_VALUE_NAME, now handled by decode_regname ().
>>> 	(fhandler_registry::readdir): Remove check for empty name, now
>>> 	handled by encode_regname ().
>>> 	(fhandler_registry::open): Remove check for DEFAULT_VALUE_NAME.
>>> 	(fhandler_registry::open_key): Fail with ENOENT if key name is empty.
>>>     
>>
>> Thanks for the patch.  Can you resend it against the latest version
>> of fhandler_registry.cc, please?  It doesn't apply cleanly anymore.
>>
>>
>>   
>
> New patch is attached, changelog is still valid.

Patch applied.  Thanks!


Corinna


-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]