This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add libz to dumper.exe link [was Re: Re: speclib vs. -lc trouble.]


Christopher Faylor wrote:
> On Mon, Apr 13, 2009 at 06:34:04PM +0100, Dave Korn wrote:
>> Christopher Faylor wrote:
>>> I think you can get by with just adding -lz to the ALL_LDFLAGS line and
>>> removing the other stuff.  The tests for libintl and libbfd are
>>> supposed to just detect if the appropriate directories are available.
>>> There isn't likely going to be a libz two levels above cygwin's source
>>> directory so I don't see any reason to specfically check for it.
>> I thought that might happen in a combined tree build with /src and /gcc
>> together?
> 
> That wasn't the intent of the current checks in the makefile.  They were
> just to detect newer versions of libbfd.a or libintl.a.  Even libintl.a
> isn't really necessary IMO.  It's not likely that is going to be under
> active development and different from what should be installed in /lib.

  Ah, OK, so just like this then:

winsup/utils/ChangeLog

	* Makefile.in (dumper.exe):  Add -lz to ALL_LDFLAGS.

  Tested by making clean then all in an existing
$objdir/i686-pc-cygwin/winsup/utils build directory.  Ok?

    cheers,
      DaveK
Index: winsup/utils/Makefile.in
===================================================================
RCS file: /cvs/src/src/winsup/utils/Makefile.in,v
retrieving revision 1.82
diff -p -u -r1.82 Makefile.in
--- winsup/utils/Makefile.in	18 Mar 2009 04:19:05 -0000	1.82
+++ winsup/utils/Makefile.in	13 Apr 2009 19:17:16 -0000
@@ -88,7 +88,7 @@ CYGWIN_BINS += dumper.exe
 dumper.o module_info.o parse_pe.o: CXXFLAGS += -I$(bupdir2)/bfd -I$(updir1)/include
 dumper.o parse_pe.o: dumper.h
 dumper.exe: module_info.o parse_pe.o
-dumper.exe: ALL_LDFLAGS += ${libbfd} ${libintl} -L$(bupdir1)/libiberty $(LIBICONV) -liberty
+dumper.exe: ALL_LDFLAGS += ${libbfd} ${libintl} -L$(bupdir1)/libiberty $(LIBICONV) -liberty -lz
 else
 all: warn_dumper
 endif

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]