This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Mon, 10 Aug 2009 00:04:52 -0400
- Subject: Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0
- References: <4A7F8FF5.5060701@gmail.com>
- Reply-to: cygwin-patches at cygwin dot com
On Mon, Aug 10, 2009 at 04:11:49AM +0100, Dave Korn wrote:
> * fhandler_tty.cc (process_input): Add dummy return to silence warning.
> (process_ioctl): Likewise.
Shouldn't these be defined with __attribute__ ((noreturn))?
> * fork.cc (cygfork): New name with friendable C++ linkage for ...
> (fork): ... un-friendable extern "C" function becomes stub calling it.
> (class frok): Declare cygfork() friend, not fork(), avoiding PR41020.
Ugh. I don't like this. fork is slow enough and complicated enough
without adding this kind of workaround. If this is a problem with
declaring an 'extern "C"' friend function then it should be fixable by
just making fork() a C++ function but exporting it as a "C" function
in cygwin.din.
Also, referring to a bug without explaining what the problem either in
the source code or the ChangeLog is a guaranteed way to cause confusion
tomorrow after a memory cache refresh.
cgf