Re: [Patch] override-able installation_root

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Nov 26 01:03, Shaddy Baddah wrote:
> Hi,
> 
> Please find attached a patch to allow for override-able
> installation_root. I actually wrote this patch for release 1.7.0-52
> motivated by the thread I started " [1.7] Alternative root
> directory. Sort of a regression."
> [http://cygwin.com/ml/cygwin/2009-07/msg00904.html]. I have forward
> ported it.

Sorry, but no.  We won't accept this patch.  We have deliberately chosen
to get away from the dependency to the Windows registry, and we really
don't want to add it back again.

Btw., for a non-trivial patch like this you need to file a copyright
assignment.  See http://cygwin.com/contrib.html, the "Before you get
started" section.

> To be honest, I don't totally understand why it was necessary, even
> though I am aware of the difference between const positioning.

That's worth a fix, afaics.  But it doesn't matter for now, so this
will have to wait until after the 1.7.1 release.

> Perhaps this needs a second look at? By the way, this problem
> pricked my curiosity leading me to ask about "regtool/registry
> interfacing and charset support"
> [http://cygwin.com/ml/cygwin/2009-07/msg00930.html].

That's on my TODO list and PTC.  It will have to wait until after 1.7.1
as well, though.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat