This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6


On 2011-02-10 19:02, Corinna Vinschen wrote:

Also, it would be nice if you would add more words to explain what your
patch is doing.  Just a patch with no explanation is not very inviting
to take a look at it at all.

this patch deals with only "two" problem. and this is "first" one.


static char * (*findenv_func)(const char *, int *) = (char *
(*)(const char *, int *)) getearly;
findenv_func is declared without __stdcall convention, and it is casting getearly having __stdcall convention with function type without __stdcall convention. to fix this problem, add __stdcall to findenv_func.


and this is "another" one.

this one deals with compilation error that gcc 4.6 complained. so i just copy & paste __attribute__((regparm (x))) from function declaration to function definition, so i must admit that this one was derived from original cygwin source code. that is, you can fix it without this patch.

> Did you read http://cygwin.com/contrib.html and the "Before you get
> started" section?  Did you already send a copyright assignment?

what i understood is, i fill out the assignment form and snail it to provided address in http://cygwin.com/assign.txt

i didn't snail it yet.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]