This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix for sigsegv in gcc 4.6


On Wed, Jul 13, 2011 at 04:40:21AM +0900, jojelino wrote:
>i think it's about 5 month between preceeding one.
>missing WINAPI(__stdcall) which should had been added for function 
>pointer type is now cause of SIGSEGV. hence it is added.
>this changes applies to winsup/cygwin/environ,autoload.cc 
>winsup/utils/mkpasswd,mkgroup.c,loadlib.h,cygpath.cc
>and in autoload.cc, ebp+4 maybe not frame pointer, but we can make sure 
>it replaces return address by using __builtin_frame_address.
>this change applies to winsup/cygwin/autoload.cc
>
>patch,changelog modified are attached as you can see.
>please review it.

Given the fact that you're changing a fundamental part of Cygwin, I'd
classify this change as nontrivial.  I think you need a copyright
assignment as per http://cygwin.com/contrib.html .

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]