This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 64bit] Fix speclib for x86_64


On Sun, Feb 17, 2013 at 02:41:41PM +0100, Corinna Vinschen wrote:
>On Feb 17 04:46, Yaakov wrote:
>
>> 2013-02-16  Yaakov Selkowitz  <yselkowitz@...>
>> 
>> 	* Makefile.in (libcygwin.a): Move --target flag from here...
>> 	(toolopts): to here, to be used by both mkimport and speclib.
>> 	* speclib: Omit leading underscore in symbol names on x86_64.
>
>The Makefile patch is fine, but for the speclib change I wonder why
>we should omit the leading underscore.  If you remove the underscore,
>you're polluting the application namespace.  Is there really a good
>reason to do that?  Did I miss something?

Doesn't the x86_64 target forego leading underscores on normal variable
names?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]