This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 64bit] Fix ONDEE for 64bit


On Mar  4 14:15, Corinna Vinschen wrote:
> On Mar  4 05:39, Yaakov wrote:
> > On Mon, 4 Mar 2013 11:51:34 +0100, Corinna Vinschen wrote:
> > > That looks good, thanks for catching this problem!  Please apply the
> > > Cygwin changes.  I'll rebuild new base packages including the gcc
> > > patches soon.
> > 
> > BTW, at some point the attached patch will also need to be added for
> > 4.8.  The libgcj ABI version changes with every GCC major.minor, and
> > this define seems to always be missed; a comment to this effect in
> > libjava/libtool-version probably wouldn't hurt.
> > 
> > 
> > Yaakov
> 
> Thanks, but here's a question:  If the libgcj ABI version really changes
> with every GCC major.minor release, wouldn't it then make sense to
> change the libgcj DLL versioning scheme so it uses the GCC major.minor
> number rather than an arbitrary version number?
> 
> In other words, why not cyggcj-4.8.dll?  This would allow easy
> automation of Cygwin's LIBGCJ_SONAME, and everybody would know what
> GCC version it's based on.

Here's my version of the LIBGCJ_SONAME setting:

#ifndef BUILDING_GCC_MAJOR
#include "bversion.h"
#endif
#define ___cyg_mkstr(x) #x
#define __cyg_mkstr(x)  ___cyg_mkstr(x)
#define LIBGCJ_SONAME "cyggcj-" __cyg_mkstr (BUILDING_GCC_MAJOR) "." \
				__cyg_mkstr (BUILDING_GCC_MINOR) ".dll"


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]