This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory

From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
To: cygwin-patches at cygwin dot com
Date: Tue, 17 Jun 2014 10:47:08 +0200
Subject: Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
Authentication-results: sourceware.org; auth=none
References: <53811668 dot 5010208 at tiscali dot co dot uk> <5382E760 dot 7 at lysator dot liu dot se> <538312E4 dot 1040201 at tiscali dot co dot uk> <5383434B dot 8070508 at lysator dot liu dot se> <53835D4E dot 9040603 at tiscali dot co dot uk> <20140526163505 dot GA7018 at ednor dot casa dot cgf dot cx> <5383A667 dot 9070407 at lysator dot liu dot se> <20140526214049 dot GB4754 at ednor dot casa dot cgf dot cx> <20140526214610 dot GA6786 at ednor dot casa dot cgf dot cx> <20140526235408 dot GA2716 at ednor dot casa dot cgf dot cx>
Reply-to: cygwin-patches at cygwin dot com

On May 26 19:54, Christopher Faylor wrote:
> On Mon, May 26, 2014 at 05:46:10PM -0400, Christopher Faylor wrote:
> >Btw, the latest version of freebsd can't have this particular problem
> >since ahostbuf is now gone.  We probably should pull in the latest version
> >into Cygwin's tree.
> 
> ...and that's apparently because Corinna added the code in question...

...and I can't remember why I added the buffer at all.  It looks like I
was trying to workaround a problem with the lifetime of the hp buffer
content.  The ahostbuf buffer is in there since I pulled the code in
from FreeBSD in 2006 so I had ... some ... reason.  Which eludes me.

I applied David's patch.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpznGlalbZQQ.pgp
Description: PGP signature

References:
- [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: David Stacey
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Peter Rosin
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: David Stacey
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Peter Rosin
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: David Stacey
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Christopher Faylor
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Peter Rosin
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Christopher Faylor
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Christopher Faylor
- Re: [PATCH] cygwin_rexec() returns pointer to deallocated memory
  - From: Christopher Faylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]