This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.

From: Takashi Yano <takashi dot yano at nifty dot ne dot jp>
To: cygwin-patches at cygwin dot com
Date: Wed, 25 Mar 2015 20:42:38 +0900
Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
Authentication-results: sourceware.org; auth=none
References: <20150228143653 dot ab0a6bf854db294105e1d5f3 at nifty dot ne dot jp> <20150228135947 dot GZ11124 at calimero dot vinschen dot de> <20150302210508 dot 1be5c1ed4753508431842913 at nifty dot ne dot jp> <20150318145854 dot GC2368 at calimero dot vinschen dot de> <20150319074942 dot 6c18c8fe0199037f028687dd at nifty dot ne dot jp> <20150319083451 dot GA8398 at calimero dot vinschen dot de> <20150320191232 dot GJ2368 at calimero dot vinschen dot de> <20150321104031 dot 9dc198eb8aa4e7652e0a7a51 at nifty dot ne dot jp> <20150323100823 dot GE3017 at calimero dot vinschen dot de>

Dear cygwin developers,

Regarding this (http://cygwin.com/ml/cygwin/2015-02/msg00929.html)
problem, I made a patch attached.

I have posted the patch to this ML with Corinna's directions.

On Mon, 23 Mar 2015 11:08:23 +0100
Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:

> However, due to the changes in fhandler_tty.cc, this patch doesn't
> apply cleanly anymore.  Any chance you could resend it (ideally to the
> cygwin-patches ML) diff'ed against git HEAD?

Please find a revised patch attached to this mail.

ChangeLog is as follows:

2015-03-25  Takashi Yano <takashi.yano@nifty.ne.jp>

	* tty.h (class tty_min): Remove variable "write_error" to which any
	errors are not currently set at anywhere.
	(class tty): Add variable "column" for handling ONOCR.
	* tty.cc (tty::init): Add initialization code for variable "column".
	* fhandler.h (class fhandler_pty_master): Remove variable "need_nl"
	which is not necessary any more. "need_nl" was needed by OPOST process
	in fhandler_pty_master::process_slave_output().
	(class fhandler_pty_common): Add function process_opost_output() for
	handling post processing for OPOST in write process.
	* fhandler_tty.cc (fhandler_pty_master::process_slave_output): Count
	TIOCPKT control byte into length to be read in TIOCPKT mode. Move
	post processing for OPOST to write process. Remove code related to
	variable "write_error". Return with EIO error if slave is already
	closed.
	(fhandler_pty_master::fhandler_pty_master): Remove initialization
	code for variable "need_nl".
	(fhandler_pty_common::process_opost_output): Add this function for
	handling of OPOST in write process. Add code to avoid blocking in
	non-blocking mode when output is suspended by ^S.
	(fhandler_pty_slave::write): Call fhandler_pty_common::
	process_opost_output() instead of WriteFile(). Remove code related to
	variable "write_error". 
	(fhandler_pty_master::doecho): Call fhandler_pty_common::
	 process_opost_output() instead of WriteFile().
	* select.cc (peek_pipe): Remove code related to variable "need_nl".

Best regards,
Takashi Yano

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>

Attachment: cygwin.patch.20150325
Description: Binary data

Follow-Ups:
- Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]