This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Support profiling of multi-threaded apps.

On Mar 10 00:35, Mark Geisert wrote:
> This is Version 4 incorporating review comments of Version 3.  This is just
> the code patch; a separate doc patch is forthcoming.

Uhm...

> +		long divisor = 1000*1000*1000; // covers positive pid_t values

...still "long"?

Was that an oversight or did you decide to keep it a long?  Either way,
no reason to resend another patch version.  If you want an int32_t here,
I fix that locally before pushing the patch.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]