This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

From: Yaakov Selkowitz <yselkowitz at cygwin dot com>
To: cygwin-patches at cygwin dot com
Date: Tue, 15 Mar 2016 10:23:30 -0500
Subject: Re: [PATCH] Cygwin: define byteswap.h inlines as macros
Authentication-results: sourceware.org; auth=none
References: <1458011636-8548-1-git-send-email-yselkowi at redhat dot com> <CAKw7uVg7QZyVJCO0miU1HXwn6PF-8yxSwzMn7s_t6CkUb2ts5w at mail dot gmail dot com> <20160315114617 dot GC7819 at calimero dot vinschen dot de>

On 2016-03-15 06:46, Corinna Vinschen wrote:

On Mar 15 11:55, VÃclav Haisman wrote:

Would it not be better to leave the original functions as they were
and simply use these defines?

#define bswap_16 bswap_16
#define bswap_32 bswap_32
#define bswap_64 bswap_64

I believe this is valid C and C++. Untested.

Already tried that, it leads to compiling issues at least with thepackage that triggered this patch in the first place.


--
Yaakov

References:
- [PATCH] Cygwin: define byteswap.h inlines as macros
  - From: Yaakov Selkowitz
- Re: [PATCH] Cygwin: define byteswap.h inlines as macros
  - From: VÃclav Haisman
- Re: [PATCH] Cygwin: define byteswap.h inlines as macros
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]