Re: [PATCH 09/11] Add c++14 sized deallocation operator

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Mar 21 15:34, Peter Foley wrote:
> On Mon, Mar 21, 2016 at 2:09 PM, Corinna Vinschen
> <corinna-cygwin@cygwin.com> wrote:
> > I realized that your orignal patch isn't invalidated by this so I tried
> > to apply it and we could then add the other stuff later.  However, it
> > doesn't compile due to a warning, and since we're always building with
> > -Werror...
> >
> > [...]/cxx.cc:33:1: error: âvoid operator delete(void*, size_t)â is a usual (non-placement) deallocation function in C++14 (or with -fsized-deallocation) [-Werror=c++14-compat]
> >  operator delete (void *p, size_t)
> >  ^
> > cc1plus: all warnings being treated as errors
> >
> > I'm not sure it's the right thing to switch to C++14 by default using
> > gcc 5.3 yet.
> 
> Ah, in that case, a better solution might be to drop this patch and
> add an explicit -std= to the Makefile.
> In that case, Cygwin won't have any issues when the default changes to
> c++14 in gcc 6.0

But using -std= when building Cygwin wouldn't change the fact that we
might need this delete anyway for applications built with -std=c++14
or do I miss something?


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature