This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.


On Apr  1 09:34, Peter Foley wrote:
> On Fri, Apr 1, 2016 at 9:12 AM, Yaakov Selkowitz <yselkowitz@cygwin.com> wrote:
> > See https://gcc.gnu.org/gcc-6/porting_to.html, section named "Optimizations
> > remove null pointer checks for this".
> 
> If there's an better way to do this, I'm all ears.

As I mentioned in my first reply, I'd prefer if the callers check the
pointer explicitly.  Changing the methods to static methods seems ...
wrong.  Ugly, if you don't mind me saying so.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]