This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Sep 2 13:36, Michael Haubenwallner wrote: > On 09/02/2016 10:52 AM, Corinna Vinschen wrote: > > On Sep 2 10:05, Michael Haubenwallner wrote: > >> Moving the allocator into pathfinder would work then, but still the > >> tmp_pathbuf instance to use has to be provided as reference. > > > > Hmm, considering that a function calling your pathfinder *might* > > need a tmp_pathbuf for its own dubious purposes, this makes sense. > > That could be easily handled via the constructor I think: > > > > tmp_pathbuf tp; > > pathfinder finder (tp); > > > > Still, since I said I'm willing to take this code as is, do you want me > > to apply it this way for now or do you want to come up with the proposed > > changes first? > > As I do prefer both pathfinder and vstrlist to not know about tmp_pathbuf > in particular but a generic memory provider only: Yes, please apply as is. Done, minus patch 4. I still think that there should be only a single pathfinder object and the rest encapsulated within and called via some pathfinder member function. I'll look into it later this year. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |