This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] cygwin: add Object Size Checking to sys/poll.h


On Nov 29 11:45, Yaakov Selkowitz wrote:
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
> ---
>  winsup/cygwin/include/ssp/poll.h | 26 ++++++++++++++++++++++++++
>  winsup/cygwin/include/sys/poll.h |  4 ++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 winsup/cygwin/include/ssp/poll.h
> 
> diff --git a/winsup/cygwin/include/ssp/poll.h b/winsup/cygwin/include/ssp/poll.h
> new file mode 100644
> index 000000000..831e626d6
> --- /dev/null
> +++ b/winsup/cygwin/include/ssp/poll.h
> @@ -0,0 +1,26 @@
> +#ifndef _SSP_POLL_H_
> +#define _SSP_POLL_H_
> +
> +#include <ssp/ssp.h>
> +
> +#if __SSP_FORTIFY_LEVEL > 0
> +__BEGIN_DECLS
> +
> +__ssp_decl(int, poll, (struct pollfd *__fds, nfds_t __nfds, int __timeout))
> +{
> +  __ssp_check (__fds, __nfds * sizeof(*__fds), __ssp_bos);
> +  return __ssp_real_poll (__fds, __nfds, __timeout);
> +}
> +
> +#if __GNU_VISIBLE
> +__ssp_decl(int, ppoll, (struct pollfd *__fds, nfds_t __nfds, const struct timespec *__timeout_ts, const sigset_t *__sigmask))
> +{
> +  __ssp_check (__fds, __nfds * sizeof(*__fds), __ssp_bos);
> +  return __ssp_real_ppoll (__fds, __nfds, __timeout_ts, __sigmask);
> +}
> +#endif
> +
> +__END_DECLS
> +
> +#endif /* __SSP_FORTIFY_LEVEL > 0 */
> +#endif /* _SSP_POLL_H_ */
> diff --git a/winsup/cygwin/include/sys/poll.h b/winsup/cygwin/include/sys/poll.h
> index 0da4c3f03..65822edb3 100644
> --- a/winsup/cygwin/include/sys/poll.h
> +++ b/winsup/cygwin/include/sys/poll.h
> @@ -47,4 +47,8 @@ extern int ppoll __P ((struct pollfd *fds, nfds_t nfds,
>  
>  __END_DECLS
>  
> +#if __SSP_FORTIFY_LEVEL > 0
> +#include <ssp/poll.h>
> +#endif
> +
>  #endif /* _SYS_POLL_H */
> -- 
> 2.15.0

ACK to both patches.

For patch series, please add a cover letter, it's not too much effort
and clearer.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]