This is the mail archive of the cygwin@sources.redhat.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Case-insensitive globbing (was RE: Cygnus question)


On Thu, Nov 09, 2000 at 11:09:16AM -0500, Town, Brad wrote:
>> The problem is that the glob() function is exported from the 
>> DLL.  I don't
>> know if its operation should be under the control of the 
>> CYGWIN environment
>> variable when it is called by the program directly.  I don't 
>> think it should
>> be actually.
>
>I agree.  I've made the change and attached new patches.
>
>> I'd appreciate it if you would test that glob's operation 
>> when called from
>> a program is unchanged, too.
>
>Source to the program I used to test is attached.
>
>So, for those of you just joining us, adding "glob" to the CYGWIN
>environment variable enables case-sensitive globbing for arguments passed on
>the command line when the program is called from a Windows shell.  With the
>patches, "glob:ignorecase" would make the globbing case-insensitive.

Looks good with a couple of minor issues (sorry).

The changes to reset the globbing case sensitivity should go right
before the call to main in dcrt0.cc.  In 1.1.5 the code which breaks apart
argv is not called for cygwin subprocesses so resetting ignore_case_glob
in build_argv is not a good idea.

So, if you could make that change and supply a ChangeLog entry for your
masterpiece, I'll incorporate it.  Also please include a statement telling
me that this is your work and that your employer has no claim to it.

Also, my preferences is to see diffs in '-u -p' format.  The '-p', in
particular, helps me understand what's going on a little more quickly.

I appreciate your efforts in doing this.  I think that this option will
make a lot of people happy.

cgf

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]