Re: gdb, insight, and tcltk

[Charles Wilson <cygwin at cwilson dot fastmail dot fm>]

The existing cygwin gdb/insight 6.8-2 package has the following change:

2007-11-30  Pedro Alves  <...>

	* i386-tdep.c (struct i386_frame_cache): Rename saved_sp to
	prev_frame_sp.  Add saved_sp_regnum field.
	(i386_alloc_frame_cache): Update.
	(i386_analyze_stack_align): Record which register holds %esp in
	saved_sp_regnum.
	(i386_analyze_register_saves): Move higher on the file.
	(i386_analyze_frame_setup): Account for register saves before stack
	adjustment.
	(i386_frame_cache): If possible, prefer reading the register that holds
	the previous stack pointer from the stack .
	(i386_frame_prev_register): Update.
	(i386_frame_args_address): New.
	(i386_frame_base): Set i386_frame_args_address as args method.

(patch vs. "regular" gdb-6.8 attached).  However, I *think* that given this:

http://sourceware.org/ml/gdb-cvs/2008-08/msg00053.html

Discussion here:
http://sourceware.org/ml/gdb-patches/2008-07/msg00575.html
http://sourceware.org/ml/gdb-patches/2008-08/msg00141.html

that Pedro's change is now unnecessary (it certainly needs a lot of TLC
to apply to 7.0, in any case).  Also: gdb/insight built without this
change seem to work ok.

Any thoughts?

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple