This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bash unable to print epoch timestamp


On Oct 28 17:20, Brian Inglis wrote:
> Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:
> > On Oct 26 19:16, Brian Inglis wrote:
> > > Sorry - redo with the file existing!
> > 
> > No worries, I applied your other patch since it also cleaned up some
> > whitespaces and, for some reason, the below patch didn't apply cleanly.
> 
> Email paste may have converted tabs to spaces - need to work out how to
> email inline text attachments without tab expansion in tbird - paste on
> gmane (below) seems to retain tabs - may try that in future. 
> 
> > There was just one problem:
> > 
> > > +	  {
> > > +	    long offset;	/* offset < 0 => W of GMT, > 0 => E of GMT:
> > > +	    offset = 0;	   subtract to get UTC */
> > 
> > This setting the offset to 0 is necessary, but commented out.  Typo?
> > I fixed this before committing the patch.
> 
> Thanks - total brain fart - Doh! Interesting that gcc -Wall -Wextra did not
> catch this - used to be reliable warning about conditionally uninitialized
> variables! 
> 
> Please check that the second set of tests in Vec1 includes the following, as
> it was not in my very first patch email, which you may not have received: 
> @@ -1502,6 +1575,7 @@ const struct test  Vec1[] = {
>  	{ CQ("%p"), 2+1, EXP(CQ("PM")) },
>  	{ CQ("%r"), 11+1, EXP(CQ("11:01:13 PM")) },
>  	{ CQ("%R"), 5+1, EXP(CQ("23:01")) },
> +	{ CQ("%s"), 2+1, EXP(CQ("1215054073")) },
>  	{ CQ("%S"), 2+1, EXP(CQ("13")) },
>  	{ CQ("%t"), 1+1, EXP(CQ("\t")) },
>  	{ CQ("%T"), 8+1, EXP(CQ("23:01:13")) },

Check.  This was in your patch so it's upstream now.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgphvO13znjrx.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]